From 97c40548036da2a0622c7e5f69fb8b90ea365c58 Mon Sep 17 00:00:00 2001 From: spwhitton Date: Sun, 19 Jun 2016 07:19:33 +0000 Subject: Added a comment --- .../comment_2_3ca5ceb0ac97451c1eea00ec72b55896._comment | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 doc/forum/Bug_with_Sbuild/comment_2_3ca5ceb0ac97451c1eea00ec72b55896._comment diff --git a/doc/forum/Bug_with_Sbuild/comment_2_3ca5ceb0ac97451c1eea00ec72b55896._comment b/doc/forum/Bug_with_Sbuild/comment_2_3ca5ceb0ac97451c1eea00ec72b55896._comment new file mode 100644 index 00000000..c2b34090 --- /dev/null +++ b/doc/forum/Bug_with_Sbuild/comment_2_3ca5ceb0ac97451c1eea00ec72b55896._comment @@ -0,0 +1,9 @@ +[[!comment format=mdwn + username="spwhitton" + subject="comment 2" + date="2016-06-19T07:19:33Z" + content=""" +Thank you for reporting this and for finding the fix, Fred. In a branch I'll be submitting soon I have modified `Ccache.hasCache` to chmod setgid the cache root, and this should propagate to all newly created subdirectories. + +Joey: what do you think about adding `cmdProperty \"chmod\" [\"-R\", \"g+s\" \"/var/cache/ccache-foo\"]` to `Ccache.hasCache` to fix existing broken setups? In my view it would be better to just add a note to the changelog suggesting this fix, but I'm not sure what you think would be best. +"""]] -- cgit v1.3-2-g0d8e From 75eb1d3743da1f7fb211c000f336c1edab43bc08 Mon Sep 17 00:00:00 2001 From: spwhitton Date: Sun, 19 Jun 2016 12:31:40 +0000 Subject: Added a comment --- .../comment_8_b4b2bd5741fbc7759d85d826dc1f9f7f._comment | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 doc/todo/merge_request:_changes_to_Reboot.hs/comment_8_b4b2bd5741fbc7759d85d826dc1f9f7f._comment diff --git a/doc/todo/merge_request:_changes_to_Reboot.hs/comment_8_b4b2bd5741fbc7759d85d826dc1f9f7f._comment b/doc/todo/merge_request:_changes_to_Reboot.hs/comment_8_b4b2bd5741fbc7759d85d826dc1f9f7f._comment new file mode 100644 index 00000000..36556924 --- /dev/null +++ b/doc/todo/merge_request:_changes_to_Reboot.hs/comment_8_b4b2bd5741fbc7759d85d826dc1f9f7f._comment @@ -0,0 +1,11 @@ +[[!comment format=mdwn + username="spwhitton" + subject="comment 8" + date="2016-06-19T12:31:40Z" + content=""" +Please consider merging my new `reboot` branch which addresses the discussion we've had. + +I also included some other improvements to `Sbuild.hs`, a bug fix in `Ccache.hs` and some GHC 7.6 compatibility fixes. With one exception,[1] I think that the changes are sufficiently self-explanatory that `git diff master..spwhitton/reboot` will be enough for you to review the branch. If not, I will happily split the commits into several branches. + +[1] I changed the haddocks on some functions in Sbuild.hs so that they will be properly hyperlinked, and did some other documentation rearrangements. +"""]] -- cgit v1.3-2-g0d8e From d5cfcd6e7ad36b1ba63893bd5c611d415cddc972 Mon Sep 17 00:00:00 2001 From: spwhitton Date: Sun, 19 Jun 2016 12:37:53 +0000 Subject: submit Firejail.hs merge request --- doc/todo/merge_request:_Firejail.hs.mdwn | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 doc/todo/merge_request:_Firejail.hs.mdwn diff --git a/doc/todo/merge_request:_Firejail.hs.mdwn b/doc/todo/merge_request:_Firejail.hs.mdwn new file mode 100644 index 00000000..c31c9167 --- /dev/null +++ b/doc/todo/merge_request:_Firejail.hs.mdwn @@ -0,0 +1,14 @@ +Please consider merging branch `firejail` of repo `https://git.spwhitton.name/propellor`. + +Changes: + +- Add `applytoList` property combinator +- Add `Propellor.Property.Firejail` module + +Comments: + +- I'm not sure whether Joey or I originally wrote `applyToList`; it's been in my config.hs for a while +- `Firejail.jailed` accepts a list of executables (and `Firejail.jailed'` is not exported) because as with `Apt.installed`, I think most users will want to jail more than one program. For example `Firejail.jailed ["firefox", "evince"]`. +- I made the build clean on GHC 7.10 but there is a warning on 7.6 that `Prelude` does not export `Foldable`. I don't know how to fix this while maintaining the 7.10 clean build, and it seems to me that having the 7.10 build be clean is more important than having the 7.6 build be clean. + +--spwhitton -- cgit v1.3-2-g0d8e