From 4773631a3854869769d23a5a696766f51322a830 Mon Sep 17 00:00:00 2001 From: spwhitton Date: Tue, 24 Nov 2015 15:29:21 +0000 Subject: apology --- ...request:_Git.repoConfigured_and_Git.repoAcceptsNonFFs_properties.mdwn | 1 + 1 file changed, 1 insertion(+) (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_Git.repoConfigured_and_Git.repoAcceptsNonFFs_properties.mdwn b/doc/todo/pull_request:_Git.repoConfigured_and_Git.repoAcceptsNonFFs_properties.mdwn index 6bdd0b42..c1df5461 100644 --- a/doc/todo/pull_request:_Git.repoConfigured_and_Git.repoAcceptsNonFFs_properties.mdwn +++ b/doc/todo/pull_request:_Git.repoConfigured_and_Git.repoAcceptsNonFFs_properties.mdwn @@ -10,3 +10,4 @@ This branch adds Note that `Git.repoConfigured` uses a tuple instead of just two function arguments in order that it can be used infix in `config.hs` when connected to other properties with `&`, as `ConfFile.containsIniSetting`. > [[done]], thank you (had to fix some indents) --[[Joey]] +>> Sorry about that! Thought I had Emacs set up for your style guide. --spwhitton -- cgit v1.3-2-g0d8e From 41884ae8eb4c80293d417352a0381cfaddad3b97 Mon Sep 17 00:00:00 2001 From: spwhitton Date: Wed, 25 Nov 2015 03:22:55 +0000 Subject: submit pull request --- ..._Locale.selectedFor_and_Locale.available_properties.mdwn | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties.mdwn (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties.mdwn b/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties.mdwn new file mode 100644 index 00000000..544948f4 --- /dev/null +++ b/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties.mdwn @@ -0,0 +1,13 @@ +Please consider merging branch `locale` of repo `https://git.spwhitton.name/propellor` + +It adds the following properties: + +- `Locale.selectedFor` to choose a locale for a locale variable +- `Locale.available`, used by `Locale.selectedFor` to ensure a locale is generated + +Example usage (I'm British but I live in the US): + + & "en_GB.UTF-8" `Locale.selectedFor` ["LANG", "LANGUAGE"] + & "en_US.UTF-8" `Locale.selectedFor` ["LC_PAPER"] + +Pretty sure I've got the indentation right this time too ;) -- cgit v1.3-2-g0d8e From 7e03e4b7a4060fa75de361339a90ed6c053c6be9 Mon Sep 17 00:00:00 2001 From: spwhitton Date: Wed, 25 Nov 2015 05:08:18 +0000 Subject: User.hasDesktopGroups bug report --- ...sktopGroups:_debian-tor_group_doesn__39__t_necessarily_exist.mdwn | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 doc/todo/User.hasDesktopGroups:_debian-tor_group_doesn__39__t_necessarily_exist.mdwn (limited to 'doc/todo') diff --git a/doc/todo/User.hasDesktopGroups:_debian-tor_group_doesn__39__t_necessarily_exist.mdwn b/doc/todo/User.hasDesktopGroups:_debian-tor_group_doesn__39__t_necessarily_exist.mdwn new file mode 100644 index 00000000..558582ab --- /dev/null +++ b/doc/todo/User.hasDesktopGroups:_debian-tor_group_doesn__39__t_necessarily_exist.mdwn @@ -0,0 +1,5 @@ +The new `User.hasDesktopGroups` tries to add a user to the group `debian-tor` which fails if this group does not exist. + +What package creates this group? If someone could let me know that, I will patch `User.hasDesktopGroups` to only try to add a user to `debian-tor` if `Apt.isInstalled "blah"` is true. + +Or perhaps Joey added this group because this group exists by default on Debian Unstable. If so then a check can be inserted for that. -- cgit v1.3-2-g0d8e From b8dd74eb947f97562c353139e0d5ad65ec718615 Mon Sep 17 00:00:00 2001 From: spwhitton Date: Wed, 25 Nov 2015 05:09:01 +0000 Subject: sign --- ...sDesktopGroups:_debian-tor_group_doesn__39__t_necessarily_exist.mdwn | 2 ++ 1 file changed, 2 insertions(+) (limited to 'doc/todo') diff --git a/doc/todo/User.hasDesktopGroups:_debian-tor_group_doesn__39__t_necessarily_exist.mdwn b/doc/todo/User.hasDesktopGroups:_debian-tor_group_doesn__39__t_necessarily_exist.mdwn index 558582ab..36a89b6f 100644 --- a/doc/todo/User.hasDesktopGroups:_debian-tor_group_doesn__39__t_necessarily_exist.mdwn +++ b/doc/todo/User.hasDesktopGroups:_debian-tor_group_doesn__39__t_necessarily_exist.mdwn @@ -3,3 +3,5 @@ The new `User.hasDesktopGroups` tries to add a user to the group `debian-tor` wh What package creates this group? If someone could let me know that, I will patch `User.hasDesktopGroups` to only try to add a user to `debian-tor` if `Apt.isInstalled "blah"` is true. Or perhaps Joey added this group because this group exists by default on Debian Unstable. If so then a check can be inserted for that. + +--[[spwhitton|https://spwhitton.name/]] -- cgit v1.3-2-g0d8e From 89240b9c622511b6e99c12a1a97aaa53cd57fb02 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Wed, 25 Nov 2015 11:20:52 -0400 Subject: close --- ...DesktopGroups:_debian-tor_group_doesn__39__t_necessarily_exist.mdwn | 3 +++ 1 file changed, 3 insertions(+) (limited to 'doc/todo') diff --git a/doc/todo/User.hasDesktopGroups:_debian-tor_group_doesn__39__t_necessarily_exist.mdwn b/doc/todo/User.hasDesktopGroups:_debian-tor_group_doesn__39__t_necessarily_exist.mdwn index 36a89b6f..b6e1ec20 100644 --- a/doc/todo/User.hasDesktopGroups:_debian-tor_group_doesn__39__t_necessarily_exist.mdwn +++ b/doc/todo/User.hasDesktopGroups:_debian-tor_group_doesn__39__t_necessarily_exist.mdwn @@ -5,3 +5,6 @@ What package creates this group? If someone could let me know that, I will patc Or perhaps Joey added this group because this group exists by default on Debian Unstable. If so then a check can be inserted for that. --[[spwhitton|https://spwhitton.name/]] + +> Noticed that too and made it only add the user to existant groups, which +> is the same approach user-setup uses. [[done]] --[[Joey]] -- cgit v1.3-2-g0d8e From df91695d31d5c4d527af0532bebf36e8580c89e9 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Wed, 25 Nov 2015 11:30:25 -0400 Subject: review --- .../comment_1_3c528827f40420e3f4001f69127a0c51._comment | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties/comment_1_3c528827f40420e3f4001f69127a0c51._comment (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties/comment_1_3c528827f40420e3f4001f69127a0c51._comment b/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties/comment_1_3c528827f40420e3f4001f69127a0c51._comment new file mode 100644 index 00000000..4d413c84 --- /dev/null +++ b/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties/comment_1_3c528827f40420e3f4001f69127a0c51._comment @@ -0,0 +1,17 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 1""" + date="2015-11-25T15:24:10Z" + content=""" +The types here don't tell me much about what values it expects. + +`selectedFor :: String -> [String] -> Property NoInfo` + +Function needs either some examples in its haddock, or better types. + +Also, the `available` property incorrectly succeeds if the locale passed to +it is not listed in locale.gen. + +(It would be nice for these properties to be revertable but that's just a +thought.) +"""]] -- cgit v1.3-2-g0d8e From 52dabb9df516932ea5cba80d9e3cf585cdae9d3c Mon Sep 17 00:00:00 2001 From: spwhitton Date: Thu, 26 Nov 2015 02:51:22 +0000 Subject: Added a comment --- .../comment_2_981a305c50d699fd3d06c39ca66107ea._comment | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties/comment_2_981a305c50d699fd3d06c39ca66107ea._comment (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties/comment_2_981a305c50d699fd3d06c39ca66107ea._comment b/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties/comment_2_981a305c50d699fd3d06c39ca66107ea._comment new file mode 100644 index 00000000..e8801aba --- /dev/null +++ b/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties/comment_2_981a305c50d699fd3d06c39ca66107ea._comment @@ -0,0 +1,7 @@ +[[!comment format=mdwn + username="spwhitton" + subject="comment 2" + date="2015-11-26T02:51:22Z" + content=""" +Thanks for the feedback. I've implemented your suggestions. Please take a look. +"""]] -- cgit v1.3-2-g0d8e From 20d3aa23df465321ec191101a631dfd5a2fc055b Mon Sep 17 00:00:00 2001 From: spwhitton Date: Thu, 26 Nov 2015 04:47:45 +0000 Subject: pull request --- ...ull_request:_patch_Apt.buildDep_to_only_proceed_if_installable.mdwn | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable.mdwn (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable.mdwn b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable.mdwn new file mode 100644 index 00000000..a27dc2e1 --- /dev/null +++ b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable.mdwn @@ -0,0 +1,3 @@ +Please consider merging branch `builddepfix` of repo `https://git.spwhitton.name/propellor` + +Patches `Apt.buildDep` to check whether the build deps are installable, so that it no longer registers a change every spin. -- cgit v1.3-2-g0d8e From 08a03bb4555e28ea7ebe5445d6dd250b06b18f45 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Thu, 26 Nov 2015 07:20:48 -0400 Subject: comment --- ...Locale.selectedFor_and_Locale.available_properties.mdwn | 2 ++ .../comment_1_88f5d79b8cd6064d1a65dec445819afe._comment | 14 ++++++++++++++ 2 files changed, 16 insertions(+) create mode 100644 doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_1_88f5d79b8cd6064d1a65dec445819afe._comment (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties.mdwn b/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties.mdwn index 544948f4..b34118f0 100644 --- a/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties.mdwn +++ b/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties.mdwn @@ -11,3 +11,5 @@ Example usage (I'm British but I live in the US): & "en_US.UTF-8" `Locale.selectedFor` ["LC_PAPER"] Pretty sure I've got the indentation right this time too ;) + +> merged, thanks! [[done]] --[[Joey]] diff --git a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_1_88f5d79b8cd6064d1a65dec445819afe._comment b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_1_88f5d79b8cd6064d1a65dec445819afe._comment new file mode 100644 index 00000000..209b62a3 --- /dev/null +++ b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_1_88f5d79b8cd6064d1a65dec445819afe._comment @@ -0,0 +1,14 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 1""" + date="2015-11-26T11:14:37Z" + content=""" +Looks like Build-Depends-Index is not handled, nor are 'a | b' build deps, +or arch-specific build deps. Since versions are skipped, if a build dep +needed a newer version, the property also wouldn't try to upgrade to it +after this change. + +I feel that parsing build deps is too complex for propellor. + +It might work to somehow detect if apt has made any changes. +"""]] -- cgit v1.3-2-g0d8e From 260b5cca74b29c03e1178cc0e69977d6c2fe89d7 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Thu, 26 Nov 2015 08:49:10 -0400 Subject: comment --- .../comment_2_23cb35130719bf1657652b76c0791947._comment | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_2_23cb35130719bf1657652b76c0791947._comment (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_2_23cb35130719bf1657652b76c0791947._comment b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_2_23cb35130719bf1657652b76c0791947._comment new file mode 100644 index 00000000..ace80098 --- /dev/null +++ b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_2_23cb35130719bf1657652b76c0791947._comment @@ -0,0 +1,10 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 2""" + date="2015-11-26T12:48:25Z" + content=""" +How about simply checking if /var/lib/dpkg/status is changed? + +I added a `changesFile` property combinator which should be helpful for +that. +"""]] -- cgit v1.3-2-g0d8e From cc4c30ffd23e5fe4ecfdfe2afb1ba5e00e51a14e Mon Sep 17 00:00:00 2001 From: spwhitton Date: Thu, 26 Nov 2015 14:39:31 +0000 Subject: Added a comment --- .../comment_3_5759b4fddf360e8a777c0339c5426b40._comment | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_3_5759b4fddf360e8a777c0339c5426b40._comment (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_3_5759b4fddf360e8a777c0339c5426b40._comment b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_3_5759b4fddf360e8a777c0339c5426b40._comment new file mode 100644 index 00000000..86f4d1de --- /dev/null +++ b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_3_5759b4fddf360e8a777c0339c5426b40._comment @@ -0,0 +1,9 @@ +[[!comment format=mdwn + username="spwhitton" + subject="comment 3" + date="2015-11-26T14:39:31Z" + content=""" +I was hoping your deep knowledge of Apt would be able to help with this! + +Before I proceed, how would you feel about catching the output of apt and only printing it if apt did make changes? Although that would make the output weirdly appear all at once when the build deps are actually installed, on the other hand it would mean no output if they're not, when we detect no changes to /var/lib/dpkg/status. +"""]] -- cgit v1.3-2-g0d8e From 703c08cd618ec3d0f299b1f715e0ebfb7233ea09 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Mon, 30 Nov 2015 13:34:17 -0400 Subject: comment --- ...mment_4_cd49645ff94d9ccec74ff72a836cd1f7._comment | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_4_cd49645ff94d9ccec74ff72a836cd1f7._comment (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_4_cd49645ff94d9ccec74ff72a836cd1f7._comment b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_4_cd49645ff94d9ccec74ff72a836cd1f7._comment new file mode 100644 index 00000000..30149a4c --- /dev/null +++ b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_4_cd49645ff94d9ccec74ff72a836cd1f7._comment @@ -0,0 +1,20 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 4""" + date="2015-11-30T16:57:45Z" + content=""" +I think it would probably depend on the user when that makes sense to do. +If I'm installing build deps over a slow network connection, I'd like to +see the output. + +It would be awesome if this transformation could be applied to any +arbitrary Property. I don't immediately know how to do that, although it +seems useful that all process spawning already goes through +concurrent-output, which can buffer the output and display it only when the +command finishes. + +Perhaps an extension to concurrent-ouput could let it buffer the output +of all commands run by a property and then discard the buffer if the +property finished with NoChange. But I don't see a way to make this work +when multiple properties are being run concurrently. +"""]] -- cgit v1.3-2-g0d8e From cf53889bcb6f4e64910a1172d1ca6ace783580a7 Mon Sep 17 00:00:00 2001 From: spwhitton Date: Wed, 2 Dec 2015 04:46:14 +0000 Subject: Added a comment --- .../comment_5_33744064a8b224d6e44e2cf8081f6a56._comment | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_5_33744064a8b224d6e44e2cf8081f6a56._comment (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_5_33744064a8b224d6e44e2cf8081f6a56._comment b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_5_33744064a8b224d6e44e2cf8081f6a56._comment new file mode 100644 index 00000000..b0283161 --- /dev/null +++ b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_5_33744064a8b224d6e44e2cf8081f6a56._comment @@ -0,0 +1,9 @@ +[[!comment format=mdwn + username="spwhitton" + subject="comment 5" + date="2015-12-02T04:46:14Z" + content=""" +I've made a property combinator `noChangeIfUnchanged` and applied it to Apt.buildDep in my `builddepfix` branch. Please take a look. + +In my testing of this, Propellor hides the output if the build deps are already installed i.e. if the property returns NoChange. So it looks like you've already implemented your awesome at some point :) +"""]] -- cgit v1.3-2-g0d8e From b2eb7434d5c95604b0326cbce6f72d8e8f2538e4 Mon Sep 17 00:00:00 2001 From: spwhitton Date: Wed, 2 Dec 2015 04:57:57 +0000 Subject: Added a comment --- .../comment_6_db48a08bc6eece590aebd41691623665._comment | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_6_db48a08bc6eece590aebd41691623665._comment (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_6_db48a08bc6eece590aebd41691623665._comment b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_6_db48a08bc6eece590aebd41691623665._comment new file mode 100644 index 00000000..85c91d65 --- /dev/null +++ b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_6_db48a08bc6eece590aebd41691623665._comment @@ -0,0 +1,7 @@ +[[!comment format=mdwn + username="spwhitton" + subject="comment 6" + date="2015-12-02T04:57:57Z" + content=""" +Seems I blanked on your `changesFile` combinator when I sat down to write mine. Taking a look now, my approach is much more direct for cases like `Apt.buildDep` when the problem is registering a change when there should be NoChange, whereas I think the intention of your changesFile is the opposite case. Though it might be nice to combine them. Let me know what you think. +"""]] -- cgit v1.3-2-g0d8e From 91cc612e67b25b1b3ade72355ed9fcd69e7e9d66 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Wed, 2 Dec 2015 12:14:34 -0400 Subject: comment --- ...ment_7_9c45f473cbc432a32bd64bbbf048fae4._comment | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_7_9c45f473cbc432a32bd64bbbf048fae4._comment (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_7_9c45f473cbc432a32bd64bbbf048fae4._comment b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_7_9c45f473cbc432a32bd64bbbf048fae4._comment new file mode 100644 index 00000000..e2611fd5 --- /dev/null +++ b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_7_9c45f473cbc432a32bd64bbbf048fae4._comment @@ -0,0 +1,21 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 7""" + date="2015-12-02T16:10:34Z" + content=""" +The two combinators are indeed very similar. The reason I wrote +changesFile the way I did is that that allows it to be applied repeatedly +when a property can change any of several files. + + trivial someprop + `changesFile` "foo" + `changesFile` "bar" + +That seems fairly likely to come up, while it would be unusual for a +property to have to change multiple files at once to be considered +to make a change at all, which is what multiple applications of +`noChangeIfUnchanged` leads to. + +But neither combinator causes apt's output to not be displayed, +which is what I thought we were talking about. +"""]] -- cgit v1.3-2-g0d8e From 15c69ffb3155feb355c663447e6ef1dbec2a6f2a Mon Sep 17 00:00:00 2001 From: spwhitton Date: Wed, 2 Dec 2015 21:44:38 +0000 Subject: Added a comment --- .../comment_8_7069f68888663fef109b82a044aeb5e1._comment | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_8_7069f68888663fef109b82a044aeb5e1._comment (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_8_7069f68888663fef109b82a044aeb5e1._comment b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_8_7069f68888663fef109b82a044aeb5e1._comment new file mode 100644 index 00000000..c05d6255 --- /dev/null +++ b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_8_7069f68888663fef109b82a044aeb5e1._comment @@ -0,0 +1,9 @@ +[[!comment format=mdwn + username="spwhitton" + subject="comment 8" + date="2015-12-02T21:44:37Z" + content=""" +My original goal was to have `Apt.buildDep` return NoChange if the build deps are already installed. As a welcome but unexplained side-effect, on my system `noChangeIfUnchanged` *does* cause apt's output not to be displayed. + +I'll think about ways to combine our two combinators. +"""]] -- cgit v1.3-2-g0d8e From 9e2115422c7d066b8ffb4ef0a4b02c7eb758db3e Mon Sep 17 00:00:00 2001 From: spwhitton Date: Thu, 3 Dec 2015 02:08:58 +0000 Subject: Added a comment --- .../comment_9_5694c0bec217d3513aa8e80f55482d75._comment | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_9_5694c0bec217d3513aa8e80f55482d75._comment (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_9_5694c0bec217d3513aa8e80f55482d75._comment b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_9_5694c0bec217d3513aa8e80f55482d75._comment new file mode 100644 index 00000000..5783dd7b --- /dev/null +++ b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_9_5694c0bec217d3513aa8e80f55482d75._comment @@ -0,0 +1,17 @@ +[[!comment format=mdwn + username="spwhitton" + subject="comment 9" + date="2015-12-03T02:08:58Z" + content=""" +I can get what I want if I use `trivial` and `changesFile` in the way you described. So please consider adding your method as a combinator: + + p `changeIfChanges` f = (trivial p) `changesFile` f + +which is okay because `trivial` is idempotent so `changeIfChanges` may be applied more than once (I've got this in my branch with a decent docstring and I've applied it to `Apt.buildDep`). + +I think that this ought to be its own combinator, rather than just a recommendation to use `trivial` and `changesFile` in such cases, because this doesn't follow the semantics of `trivial`: it's not necessarily the case that it is the same amount of work to check if the property needs to be ensured as it is to ensure it. + +(In this language, my `noChangeIfUnchanged` could be called `changeOnlyIfChanges`. I agree that it's very unlikely to useful.) + +(Again, on my machine, applying `changeIfChanges` to `Apt.buildDep` magically hides apt's output if the build-deps are already installed.) +"""]] -- cgit v1.3-2-g0d8e From f71d10672e035d81c4ee20d1394e5b100d3a7b2f Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Thu, 3 Dec 2015 11:25:27 -0400 Subject: comment --- ...nt_10_eb58216ef1172ee5b882090dab7219ce._comment | 32 ++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_10_eb58216ef1172ee5b882090dab7219ce._comment (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_10_eb58216ef1172ee5b882090dab7219ce._comment b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_10_eb58216ef1172ee5b882090dab7219ce._comment new file mode 100644 index 00000000..3799a012 --- /dev/null +++ b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_10_eb58216ef1172ee5b882090dab7219ce._comment @@ -0,0 +1,32 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 10""" + date="2015-12-03T15:05:21Z" + content=""" + + trivial (trivial p `changesFile` f) `changesFile` f' + +The parenthesized property here is all marked trivial, so a change to f +won't result in MadeChange, though a change to f' will. + +The only way propellor might intercept the output of a program is if you're +using the new Concurrent module. In that case it should buffer program output +and display it all at once. There could potentially be a bug there that +hid program output. I certianly can't reproduce changesFile hiding the output +of a program: + + *Propellor.Property.Apt> runPropellor (Host "localhost" [] mempty) $ ensureProperty $ trivial (buildDep ["git-annex"]) `changesFile` "/var/lib/dpkg/status" + Reading package lists... Done + Building dependency tree + Reading state information... Done + 0 upgraded, 0 newly installed, 0 to remove and 707 not upgraded. + NoChange + + *Propellor.Property.Apt Propellor.Property.Concurrent> withConcurrentOutput $ runPropellor (Host "localhost" [] mempty) $ ensureProperty $ (trivial (buildDep ["git-annex"]) `changesFile` "/var/lib/dpkg/status") `concurrently` cmdProperty "echo" ["hi"] + hi + Reading package lists... + Building dependency tree... + Reading state information... + 0 upgraded, 0 newly installed, 0 to remove and 707 not upgraded. + MadeChange +"""]] -- cgit v1.3-2-g0d8e From 5c6a43c3b888242443d790efbc1f9282e4e5675c Mon Sep 17 00:00:00 2001 From: spwhitton Date: Thu, 3 Dec 2015 23:29:57 +0000 Subject: Added a comment --- .../comment_11_bee4b2397dfb28a3791081a83d725daf._comment | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_11_bee4b2397dfb28a3791081a83d725daf._comment (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_11_bee4b2397dfb28a3791081a83d725daf._comment b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_11_bee4b2397dfb28a3791081a83d725daf._comment new file mode 100644 index 00000000..f4df5527 --- /dev/null +++ b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_11_bee4b2397dfb28a3791081a83d725daf._comment @@ -0,0 +1,7 @@ +[[!comment format=mdwn + username="spwhitton" + subject="comment 11" + date="2015-12-03T23:29:57Z" + content=""" +Thank you for your feedback. I'll think about how I might rewrite `changeIfChanges` to avoid that problem with `trivial`, and I'll try to pin down the hiding of apt's output. +"""]] -- cgit v1.3-2-g0d8e From db0a38f02e1dda6ce35c782fa6132f344b0905d1 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Sat, 5 Dec 2015 18:57:56 -0400 Subject: followup --- ...tch_Apt.buildDep_to_only_proceed_if_installable.mdwn | 3 +++ ...comment_12_1e09f5a3f4565a9392d7b50b703a8a69._comment | 17 +++++++++++++++++ 2 files changed, 20 insertions(+) create mode 100644 doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_12_1e09f5a3f4565a9392d7b50b703a8a69._comment (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable.mdwn b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable.mdwn index a27dc2e1..275ea9f5 100644 --- a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable.mdwn +++ b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable.mdwn @@ -1,3 +1,6 @@ Please consider merging branch `builddepfix` of repo `https://git.spwhitton.name/propellor` Patches `Apt.buildDep` to check whether the build deps are installable, so that it no longer registers a change every spin. + +> Apt.buildDep now checks if the dpkg status file has changed, so [[done]] +> --[[Joey]] diff --git a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_12_1e09f5a3f4565a9392d7b50b703a8a69._comment b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_12_1e09f5a3f4565a9392d7b50b703a8a69._comment new file mode 100644 index 00000000..3db6fd1b --- /dev/null +++ b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_12_1e09f5a3f4565a9392d7b50b703a8a69._comment @@ -0,0 +1,17 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 12""" + date="2015-12-05T22:52:42Z" + content=""" +I had a thought about this; +[[trivial is a code smell|type-level_trivial_avoidance]] and adding +UncheckedProperty type avoids needing to use trivial. + +So, now cmdProperty, runApt, and other things that make a Property but +can't really detect when it MadeChange can instead make an +UncheckedProperty, and changesFile is one of the ways to convert that into +a Property. + +My implementation also allows applying changesFile multiple times, to +detect a change to multiple files. +"""]] -- cgit v1.3-2-g0d8e From b29398d8813e67068c4c5fdeaa148d77ef940d2a Mon Sep 17 00:00:00 2001 From: spwhitton Date: Sun, 6 Dec 2015 17:17:34 +0000 Subject: Added a comment --- .../comment_13_54de6d1c5351e9303c190edda7e7a33f._comment | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_13_54de6d1c5351e9303c190edda7e7a33f._comment (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_13_54de6d1c5351e9303c190edda7e7a33f._comment b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_13_54de6d1c5351e9303c190edda7e7a33f._comment new file mode 100644 index 00000000..72f6bf40 --- /dev/null +++ b/doc/todo/pull_request:_patch_Apt.buildDep_to_only_proceed_if_installable/comment_13_54de6d1c5351e9303c190edda7e7a33f._comment @@ -0,0 +1,7 @@ +[[!comment format=mdwn + username="spwhitton" + subject="comment 13" + date="2015-12-06T17:17:34Z" + content=""" +Very nice. Thank you for writing it up in full so Haskell beginners like me can learn about the flexibilities and limitations of programming with Haskell types. +"""]] -- cgit v1.3-2-g0d8e From a6a97e044e0bfef76cb6ff5d98cfe16cf4483d15 Mon Sep 17 00:00:00 2001 From: spwhitton Date: Sun, 6 Dec 2015 20:03:58 +0000 Subject: proposal --- ..._95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn (limited to 'doc/todo') diff --git a/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn new file mode 100644 index 00000000..14fd1fe1 --- /dev/null +++ b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn @@ -0,0 +1,13 @@ +I'd like to patch the `/usr/bin/propellor` wrapper to check for two environment variables. I'm posting my proposal here to see whether Joey would be willing to merge such a patch before starting to write it. + +# Proposal + +- if the branch currently checked out in the `~/.propellor` repository does not match `PROPELLOR_SPIN_BRANCH`, Propellor would refuse to spin + +- if the `PROPELLOR_DIRTY_NOSPIN` variable is set, Propellor will refuse to spin if the `~/.propellor` repository contains uncommitted changes + +# Rationale + +`PROPELLOR_SPIN_BRANCH` is to prevent foot-shooting. When working on a feature branch one might forget to check out one's usual config branch before spinning. If the host that is spun is configured with `Cron.runPropellor`, it will be set to pull from the feature branch. If the user doesn't realise that this has happened, they might make further commits to their usual config branch and expect them to have propagated to the host by means of its `Cron.runPropellor` cronjob, but they won't reach the host until the next manual spin from the correct branch. Of course there are other possible foot-shootings available in this area. + +`PROPELLOR_DIRTY_NOSPIN` is to prevent configuration changes ending up in commits made with the undescriptive commit message "propellor spin". I understand that it doesn't bother Joey, but I want all configuration changes to be recorded with a descriptive commit message because it makes using `git revert` and `git cherry-pick` easier. So for users like me this environment variable is a useful check. -- cgit v1.3-2-g0d8e From 3e2dc047b337f60aa1d42c4fc3913d52467091f6 Mon Sep 17 00:00:00 2001 From: spwhitton Date: Sun, 6 Dec 2015 20:04:21 +0000 Subject: tense --- ...R__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'doc/todo') diff --git a/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn index 14fd1fe1..115b8740 100644 --- a/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn +++ b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn @@ -4,7 +4,7 @@ I'd like to patch the `/usr/bin/propellor` wrapper to check for two environment - if the branch currently checked out in the `~/.propellor` repository does not match `PROPELLOR_SPIN_BRANCH`, Propellor would refuse to spin -- if the `PROPELLOR_DIRTY_NOSPIN` variable is set, Propellor will refuse to spin if the `~/.propellor` repository contains uncommitted changes +- if the `PROPELLOR_DIRTY_NOSPIN` variable is set, Propellor would refuse to spin if the `~/.propellor` repository contains uncommitted changes # Rationale -- cgit v1.3-2-g0d8e From 811a45ea5c05bcc5c3e385fab686cc6778e3f8d5 Mon Sep 17 00:00:00 2001 From: spwhitton Date: Sun, 6 Dec 2015 20:04:36 +0000 Subject: sign --- ...R__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn | 2 ++ 1 file changed, 2 insertions(+) (limited to 'doc/todo') diff --git a/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn index 115b8740..10885389 100644 --- a/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn +++ b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn @@ -11,3 +11,5 @@ I'd like to patch the `/usr/bin/propellor` wrapper to check for two environment `PROPELLOR_SPIN_BRANCH` is to prevent foot-shooting. When working on a feature branch one might forget to check out one's usual config branch before spinning. If the host that is spun is configured with `Cron.runPropellor`, it will be set to pull from the feature branch. If the user doesn't realise that this has happened, they might make further commits to their usual config branch and expect them to have propagated to the host by means of its `Cron.runPropellor` cronjob, but they won't reach the host until the next manual spin from the correct branch. Of course there are other possible foot-shootings available in this area. `PROPELLOR_DIRTY_NOSPIN` is to prevent configuration changes ending up in commits made with the undescriptive commit message "propellor spin". I understand that it doesn't bother Joey, but I want all configuration changes to be recorded with a descriptive commit message because it makes using `git revert` and `git cherry-pick` easier. So for users like me this environment variable is a useful check. + +--[[spwhitton]] -- cgit v1.3-2-g0d8e From b3ba2e63e9e6c1b6ce3cd28596576c1f94ea32a4 Mon Sep 17 00:00:00 2001 From: spwhitton Date: Sun, 6 Dec 2015 20:05:16 +0000 Subject: fix sig --- ...R__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'doc/todo') diff --git a/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn index 10885389..3c152e85 100644 --- a/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn +++ b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn @@ -12,4 +12,4 @@ I'd like to patch the `/usr/bin/propellor` wrapper to check for two environment `PROPELLOR_DIRTY_NOSPIN` is to prevent configuration changes ending up in commits made with the undescriptive commit message "propellor spin". I understand that it doesn't bother Joey, but I want all configuration changes to be recorded with a descriptive commit message because it makes using `git revert` and `git cherry-pick` easier. So for users like me this environment variable is a useful check. ---[[spwhitton]] +--[[spwhitton|https://spwhitton.name]] -- cgit v1.3-2-g0d8e From cf45e508b6f607bf16ab345e14f69e0cee3cf305 Mon Sep 17 00:00:00 2001 From: spwhitton Date: Sun, 6 Dec 2015 20:06:10 +0000 Subject: expand desc --- ...R__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'doc/todo') diff --git a/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn index 3c152e85..8d3670a5 100644 --- a/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn +++ b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn @@ -8,7 +8,7 @@ I'd like to patch the `/usr/bin/propellor` wrapper to check for two environment # Rationale -`PROPELLOR_SPIN_BRANCH` is to prevent foot-shooting. When working on a feature branch one might forget to check out one's usual config branch before spinning. If the host that is spun is configured with `Cron.runPropellor`, it will be set to pull from the feature branch. If the user doesn't realise that this has happened, they might make further commits to their usual config branch and expect them to have propagated to the host by means of its `Cron.runPropellor` cronjob, but they won't reach the host until the next manual spin from the correct branch. Of course there are other possible foot-shootings available in this area. +`PROPELLOR_SPIN_BRANCH` is to prevent foot-shooting. When working on a feature branch one might forget to check out one's usual config branch before spinning. If the host that is spun is configured with `Cron.runPropellor`, it will be set to pull from the feature branch. If the user doesn't realise that this has happened, they might make further commits to their usual config branch and expect them to have propagated to the host by means of its `Cron.runPropellor` cronjob, but they won't reach the host until the next manual spin from the correct branch. Of course there are other possible foot-shootings available in this area that this environment variable would prevent. `PROPELLOR_DIRTY_NOSPIN` is to prevent configuration changes ending up in commits made with the undescriptive commit message "propellor spin". I understand that it doesn't bother Joey, but I want all configuration changes to be recorded with a descriptive commit message because it makes using `git revert` and `git cherry-pick` easier. So for users like me this environment variable is a useful check. -- cgit v1.3-2-g0d8e From aad109c66f57abbfc5cfb0dc8288928ee9a01a7e Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Sun, 6 Dec 2015 17:26:19 -0400 Subject: comment --- ...ent_1_432c6009fbe2309af81a47658173f753._comment | 27 ++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN/comment_1_432c6009fbe2309af81a47658173f753._comment (limited to 'doc/todo') diff --git a/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN/comment_1_432c6009fbe2309af81a47658173f753._comment b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN/comment_1_432c6009fbe2309af81a47658173f753._comment new file mode 100644 index 00000000..9b9ea864 --- /dev/null +++ b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN/comment_1_432c6009fbe2309af81a47658173f753._comment @@ -0,0 +1,27 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 1""" + date="2015-12-06T21:14:36Z" + content=""" +I'd use `PROPELLOR_SPIN_BRANCH`. No objections to `PROPELLOR_DIRTY_NOSPIN` +as long as it's not default. + +Note that Cron.runPropellor does not use /usr/bin/propellor, and there are +other ways of running propellor that don't use that wrapper. So I don't +think the wrapper is the place to implement this kind of thing. + +Why use environment variables for configuration? That makes it hard to make +sure propellor gets the same configuration every way it can be run. And, +propellor has a config file. :) + +Implementation could be something like, add a `configuredMain` that takes a +monoidial configuration value for such global config settings. +(so `defaultMain = configuredMain mempty`) + +Hmm, I suppose the issue with `PROPELLOR_SPIN_BRANCH` is that when a +different branch is checked out, that branch's config.hs would not have that +configured, or would perhaps set it to use that branch. So, that's why +you were thinking environment variables? + +Maybe use git-config? +"""]] -- cgit v1.3-2-g0d8e From 086563af61f4cdc3c9041167d3002a7f0089902c Mon Sep 17 00:00:00 2001 From: spwhitton Date: Sun, 6 Dec 2015 22:24:06 +0000 Subject: Added a comment --- .../comment_2_3ddaec3927b4a4aefad45a02e83476dc._comment | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN/comment_2_3ddaec3927b4a4aefad45a02e83476dc._comment (limited to 'doc/todo') diff --git a/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN/comment_2_3ddaec3927b4a4aefad45a02e83476dc._comment b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN/comment_2_3ddaec3927b4a4aefad45a02e83476dc._comment new file mode 100644 index 00000000..045cd927 --- /dev/null +++ b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN/comment_2_3ddaec3927b4a4aefad45a02e83476dc._comment @@ -0,0 +1,9 @@ +[[!comment format=mdwn + username="spwhitton" + subject="comment 2" + date="2015-12-06T22:24:06Z" + content=""" +I was thinking environment variables because I saw both of these as just safety checks for the user, spinning hosts from their xterm on their laptop. I'll implement both as `git-config` variables; that's a good idea as it covers more cases. + +I don't think that this patch need touch the propellor executable run by `Cron.runPropellor`, because if the check has already ensured that the correct branch got pushed to the host during the most recent spin, then `propellor_cronjob` is guaranteed to pull the correct branch. +"""]] -- cgit v1.3-2-g0d8e From a6baf79237033b42bed78aab4fd0dc34b933287a Mon Sep 17 00:00:00 2001 From: spwhitton Date: Sun, 6 Dec 2015 23:58:51 +0000 Subject: Added a comment --- .../comment_3_cf7b9d698c67e7a12d07a53667241092._comment | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN/comment_3_cf7b9d698c67e7a12d07a53667241092._comment (limited to 'doc/todo') diff --git a/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN/comment_3_cf7b9d698c67e7a12d07a53667241092._comment b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN/comment_3_cf7b9d698c67e7a12d07a53667241092._comment new file mode 100644 index 00000000..ca22b1d3 --- /dev/null +++ b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN/comment_3_cf7b9d698c67e7a12d07a53667241092._comment @@ -0,0 +1,9 @@ +[[!comment format=mdwn + username="spwhitton" + subject="comment 3" + date="2015-12-06T23:58:51Z" + content=""" +I've implemented these in the `safetychecks` branch of `https://git.spwhitton.name/propellor`. + +A nice side effect of my implementation is that the spin only errors out after there's been an attempt to compile Propellor. So you can run `propellor --spin` in order to have GHC typecheck your code on a feature branch. +"""]] -- cgit v1.3-2-g0d8e From d763549d77902f600d6cc8ced2c0759e718eb6f3 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 8 Dec 2015 12:01:11 -0400 Subject: close --- ...R__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn | 2 ++ 1 file changed, 2 insertions(+) (limited to 'doc/todo') diff --git a/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn index 8d3670a5..fad2a1e0 100644 --- a/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn +++ b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN.mdwn @@ -13,3 +13,5 @@ I'd like to patch the `/usr/bin/propellor` wrapper to check for two environment `PROPELLOR_DIRTY_NOSPIN` is to prevent configuration changes ending up in commits made with the undescriptive commit message "propellor spin". I understand that it doesn't bother Joey, but I want all configuration changes to be recorded with a descriptive commit message because it makes using `git revert` and `git cherry-pick` easier. So for users like me this environment variable is a useful check. --[[spwhitton|https://spwhitton.name]] + +> nice work! [[merged|done]] --[[Joey]] -- cgit v1.3-2-g0d8e From 8d8ccb74f28345f5a073828fca5d9eb603ff26b7 Mon Sep 17 00:00:00 2001 From: gueux Date: Fri, 11 Dec 2015 13:15:57 +0000 Subject: --- doc/todo/should_not_overwrite_unchanged_private_files.mdwn | 1 + 1 file changed, 1 insertion(+) create mode 100644 doc/todo/should_not_overwrite_unchanged_private_files.mdwn (limited to 'doc/todo') diff --git a/doc/todo/should_not_overwrite_unchanged_private_files.mdwn b/doc/todo/should_not_overwrite_unchanged_private_files.mdwn new file mode 100644 index 00000000..090849f1 --- /dev/null +++ b/doc/todo/should_not_overwrite_unchanged_private_files.mdwn @@ -0,0 +1 @@ +A private file is overwritten by propellor at each run. It is not optimal when the host runs an integrity checker (like samhain). It would be great to have a file modified only if necessary. -- cgit v1.3-2-g0d8e From 6fc3f3012452f948d32448d2c40de60b838217a1 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 11 Dec 2015 12:40:44 -0400 Subject: comment --- ...mment_1_d65fd2ebfca6b9994db9512232ce78ff._comment | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 doc/todo/should_not_overwrite_unchanged_private_files/comment_1_d65fd2ebfca6b9994db9512232ce78ff._comment (limited to 'doc/todo') diff --git a/doc/todo/should_not_overwrite_unchanged_private_files/comment_1_d65fd2ebfca6b9994db9512232ce78ff._comment b/doc/todo/should_not_overwrite_unchanged_private_files/comment_1_d65fd2ebfca6b9994db9512232ce78ff._comment new file mode 100644 index 00000000..6e44dde6 --- /dev/null +++ b/doc/todo/should_not_overwrite_unchanged_private_files/comment_1_d65fd2ebfca6b9994db9512232ce78ff._comment @@ -0,0 +1,20 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 1""" + date="2015-12-11T16:35:43Z" + content=""" +Doesn't rebuilding propellor overwrite lots of files too? Is the +privdata.local file somehow a particular problem, perhaps becuase +of its permissions? + +You should find it easy enough to make propellor read any existing +file and only update the file when there are changes. But it seems to me +your integrity checker would still go off whenever a new version +of the file is legitimately reveiced. Perhaps it would be better to +write a property to configure your integrity checker to not fire on +this file? + +(I've thought from time to time about having rsync update the privdata.local +file. Since it's unchanged in most spins, that would probably save network +bandwidth.) +"""]] -- cgit v1.3-2-g0d8e From 7bea86e0efb9a914b85459811113b8bc3ae47b9e Mon Sep 17 00:00:00 2001 From: gueux Date: Sun, 13 Dec 2015 20:44:20 +0000 Subject: Added a comment --- .../comment_2_2e37e89b8f108f027d2d8c5962a24536._comment | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 doc/todo/should_not_overwrite_unchanged_private_files/comment_2_2e37e89b8f108f027d2d8c5962a24536._comment (limited to 'doc/todo') diff --git a/doc/todo/should_not_overwrite_unchanged_private_files/comment_2_2e37e89b8f108f027d2d8c5962a24536._comment b/doc/todo/should_not_overwrite_unchanged_private_files/comment_2_2e37e89b8f108f027d2d8c5962a24536._comment new file mode 100644 index 00000000..dbf7ac3b --- /dev/null +++ b/doc/todo/should_not_overwrite_unchanged_private_files/comment_2_2e37e89b8f108f027d2d8c5962a24536._comment @@ -0,0 +1,9 @@ +[[!comment format=mdwn + username="gueux" + subject="comment 2" + date="2015-12-13T20:44:20Z" + content=""" +The integrity checker should shout everytime it finds a new version of a file (and if a new version of the file is legitimately received, I can then run \"samhain -t update -m none --interactive\"). As the private files are very often sensitive information, the integrity should shout on them too. To me, it sounds like it should be the default (it may also be useful for backup systems that check when a file was last modified?), but I dont see exactly what should be changed to enable that. What do you think? + +Having privdata uploaded only if it is updated would certainly be cool for slow internet connections. +"""]] -- cgit v1.3-2-g0d8e From ea1b7f15af0fd277ec5431d034b6aecaa45a8d72 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Sun, 13 Dec 2015 22:05:42 -0400 Subject: comment --- .../comment_3_5e7127049c1798dfc830d33da0fd78d7._comment | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 doc/todo/should_not_overwrite_unchanged_private_files/comment_3_5e7127049c1798dfc830d33da0fd78d7._comment (limited to 'doc/todo') diff --git a/doc/todo/should_not_overwrite_unchanged_private_files/comment_3_5e7127049c1798dfc830d33da0fd78d7._comment b/doc/todo/should_not_overwrite_unchanged_private_files/comment_3_5e7127049c1798dfc830d33da0fd78d7._comment new file mode 100644 index 00000000..b2de7f4a --- /dev/null +++ b/doc/todo/should_not_overwrite_unchanged_private_files/comment_3_5e7127049c1798dfc830d33da0fd78d7._comment @@ -0,0 +1,8 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 3""" + date="2015-12-14T02:03:40Z" + content=""" +The place the privdata file gets saved is Spin.hs, when `update` +calls "writeFileProtected privfile" +"""]] -- cgit v1.3-2-g0d8e From 0b0e8aaf827b0de5232b648142873e29504f2076 Mon Sep 17 00:00:00 2001 From: spwhitton Date: Mon, 28 Dec 2015 16:58:41 +0000 Subject: pull request --- doc/todo/silence_xargs_when_hothasktags_not_installed.mdwn | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 doc/todo/silence_xargs_when_hothasktags_not_installed.mdwn (limited to 'doc/todo') diff --git a/doc/todo/silence_xargs_when_hothasktags_not_installed.mdwn b/doc/todo/silence_xargs_when_hothasktags_not_installed.mdwn new file mode 100644 index 00000000..ff34006a --- /dev/null +++ b/doc/todo/silence_xargs_when_hothasktags_not_installed.mdwn @@ -0,0 +1,7 @@ +Please consider merging branch `hothasktags` of my repo `https://git.spwhitton.name/propellor` + +Moves the `2>/dev/null` redirection in the Makefile rule for `tags` in order to silence xargs if hothasktags is not installed (avoids `xargs: hothasktags: No such file or directory`). + +I assume that your originally intention was not to cause an error if hothasktags is not installed, since you have `|| true` at the end of the line. However, someone trying to build propellor's Debian package saw the error output from xargs and thought it meant hothasktags should be a build-dep. This patch prevents someone thinking that. + +-- [[spwhitton|https://spwhitton.name]] -- cgit v1.3-2-g0d8e From c98120966770db0329589c2aaf76e36131052cbd Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Mon, 28 Dec 2015 14:33:52 -0400 Subject: merged --- doc/todo/silence_xargs_when_hothasktags_not_installed.mdwn | 2 ++ 1 file changed, 2 insertions(+) (limited to 'doc/todo') diff --git a/doc/todo/silence_xargs_when_hothasktags_not_installed.mdwn b/doc/todo/silence_xargs_when_hothasktags_not_installed.mdwn index ff34006a..efa17987 100644 --- a/doc/todo/silence_xargs_when_hothasktags_not_installed.mdwn +++ b/doc/todo/silence_xargs_when_hothasktags_not_installed.mdwn @@ -5,3 +5,5 @@ Moves the `2>/dev/null` redirection in the Makefile rule for `tags` in order to I assume that your originally intention was not to cause an error if hothasktags is not installed, since you have `|| true` at the end of the line. However, someone trying to build propellor's Debian package saw the error output from xargs and thought it meant hothasktags should be a build-dep. This patch prevents someone thinking that. -- [[spwhitton|https://spwhitton.name]] + +> [[merged|done]] --[[Joey]] -- cgit v1.3-2-g0d8e From bc5f7a81f0c7a62f788eb05c101c5bef593ba0b5 Mon Sep 17 00:00:00 2001 From: spwhitton Date: Tue, 5 Jan 2016 12:47:32 +0000 Subject: pull request --- doc/todo/pull_request:_Git.bareRepoDefaultBranch_property.mdwn | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 doc/todo/pull_request:_Git.bareRepoDefaultBranch_property.mdwn (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_Git.bareRepoDefaultBranch_property.mdwn b/doc/todo/pull_request:_Git.bareRepoDefaultBranch_property.mdwn new file mode 100644 index 00000000..c9a6cc2f --- /dev/null +++ b/doc/todo/pull_request:_Git.bareRepoDefaultBranch_property.mdwn @@ -0,0 +1,5 @@ +Please consider merging branch `defaultbranch` of repo `https://git.spwhitton.name/propellor`. + +This branch adds a new property `Git.bareRepoDefaultBranch` which sets the default branch of a bare repository. This is useful when hosting git repositories that don't have a master branch, so that something gets checked out when someone clones them. + +I limited this property to bare repositories since the notion of a default branch for a non-bare repository doesn't really make sense. -- cgit v1.3-2-g0d8e From 1b4a40210fe0f9f5bb151aa9e2707837cc193883 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 5 Jan 2016 13:34:22 -0400 Subject: cloe --- doc/todo/pull_request:_Git.bareRepoDefaultBranch_property.mdwn | 2 ++ 1 file changed, 2 insertions(+) (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_Git.bareRepoDefaultBranch_property.mdwn b/doc/todo/pull_request:_Git.bareRepoDefaultBranch_property.mdwn index c9a6cc2f..038ab876 100644 --- a/doc/todo/pull_request:_Git.bareRepoDefaultBranch_property.mdwn +++ b/doc/todo/pull_request:_Git.bareRepoDefaultBranch_property.mdwn @@ -3,3 +3,5 @@ Please consider merging branch `defaultbranch` of repo `https://git.spwhitton.na This branch adds a new property `Git.bareRepoDefaultBranch` which sets the default branch of a bare repository. This is useful when hosting git repositories that don't have a master branch, so that something gets checked out when someone clones them. I limited this property to bare repositories since the notion of a default branch for a non-bare repository doesn't really make sense. + +> [[merged|done]] --[[Joey]] -- cgit v1.3-2-g0d8e From 143d77adcdba4800099dd7ab752f88dddde579c2 Mon Sep 17 00:00:00 2001 From: spwhitton Date: Sun, 17 Jan 2016 21:16:47 +0000 Subject: submit pull request --- ...ducible___47__usr__47__src__47__propellor__47__propellor.git.mdwn | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 doc/todo/pull_request:_reproducible___47__usr__47__src__47__propellor__47__propellor.git.mdwn (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_reproducible___47__usr__47__src__47__propellor__47__propellor.git.mdwn b/doc/todo/pull_request:_reproducible___47__usr__47__src__47__propellor__47__propellor.git.mdwn new file mode 100644 index 00000000..708c346c --- /dev/null +++ b/doc/todo/pull_request:_reproducible___47__usr__47__src__47__propellor__47__propellor.git.mdwn @@ -0,0 +1,5 @@ +Please consider merging branch `reproducible` of repository `https://git.spwhitton.name/propellor`. + +This makes the generated `/usr/src/propellor/propellor.git` reproducible, so that the whole Debian package can be built reproducibly. + +So far as I can tell, this is the only part of the propellor build that is not reproducible at present. It's also the only issue listed on the [[reproducible builds team website|https://reproducible.debian.net/rb-pkg/unstable/amd64/propellor.html]]. -- cgit v1.3-2-g0d8e From 6f40856880913837ba599f1101b02f4e7a95f0a7 Mon Sep 17 00:00:00 2001 From: spwhitton Date: Sun, 17 Jan 2016 21:17:34 +0000 Subject: sign --- ...producible___47__usr__47__src__47__propellor__47__propellor.git.mdwn | 2 ++ 1 file changed, 2 insertions(+) (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_reproducible___47__usr__47__src__47__propellor__47__propellor.git.mdwn b/doc/todo/pull_request:_reproducible___47__usr__47__src__47__propellor__47__propellor.git.mdwn index 708c346c..546cce37 100644 --- a/doc/todo/pull_request:_reproducible___47__usr__47__src__47__propellor__47__propellor.git.mdwn +++ b/doc/todo/pull_request:_reproducible___47__usr__47__src__47__propellor__47__propellor.git.mdwn @@ -3,3 +3,5 @@ Please consider merging branch `reproducible` of repository `https://git.spwhitt This makes the generated `/usr/src/propellor/propellor.git` reproducible, so that the whole Debian package can be built reproducibly. So far as I can tell, this is the only part of the propellor build that is not reproducible at present. It's also the only issue listed on the [[reproducible builds team website|https://reproducible.debian.net/rb-pkg/unstable/amd64/propellor.html]]. + +--spwhitton -- cgit v1.3-2-g0d8e From e30d6174f680c061298d09ecbcecd989b900a7c1 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Mon, 18 Jan 2016 13:21:27 -0400 Subject: comment --- ...___47__usr__47__src__47__propellor__47__propellor.git.mdwn | 2 ++ .../comment_1_d1ed8af3172ada81d166063f0b38e23a._comment | 11 +++++++++++ 2 files changed, 13 insertions(+) create mode 100644 doc/todo/pull_request:_reproducible___47__usr__47__src__47__propellor__47__propellor.git/comment_1_d1ed8af3172ada81d166063f0b38e23a._comment (limited to 'doc/todo') diff --git a/doc/todo/pull_request:_reproducible___47__usr__47__src__47__propellor__47__propellor.git.mdwn b/doc/todo/pull_request:_reproducible___47__usr__47__src__47__propellor__47__propellor.git.mdwn index 546cce37..0e122ddc 100644 --- a/doc/todo/pull_request:_reproducible___47__usr__47__src__47__propellor__47__propellor.git.mdwn +++ b/doc/todo/pull_request:_reproducible___47__usr__47__src__47__propellor__47__propellor.git.mdwn @@ -5,3 +5,5 @@ This makes the generated `/usr/src/propellor/propellor.git` reproducible, so tha So far as I can tell, this is the only part of the propellor build that is not reproducible at present. It's also the only issue listed on the [[reproducible builds team website|https://reproducible.debian.net/rb-pkg/unstable/amd64/propellor.html]]. --spwhitton + +> merged; [[done]] --[[Joey]] diff --git a/doc/todo/pull_request:_reproducible___47__usr__47__src__47__propellor__47__propellor.git/comment_1_d1ed8af3172ada81d166063f0b38e23a._comment b/doc/todo/pull_request:_reproducible___47__usr__47__src__47__propellor__47__propellor.git/comment_1_d1ed8af3172ada81d166063f0b38e23a._comment new file mode 100644 index 00000000..1af7a9e6 --- /dev/null +++ b/doc/todo/pull_request:_reproducible___47__usr__47__src__47__propellor__47__propellor.git/comment_1_d1ed8af3172ada81d166063f0b38e23a._comment @@ -0,0 +1,11 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 1""" + date="2016-01-18T17:17:55Z" + content=""" +I've merged that, thanks. + +IIRC, ghc only produces reproducible output when not doing any parallel +building. If that is currently avoided, it's probably only by accident. +It might be worth forcing -j1 when building the debian package. +"""]] -- cgit v1.3-2-g0d8e From c6651b2fa7fa7ab3c31f340524e3473301e14a3b Mon Sep 17 00:00:00 2001 From: "cmt.miniBill@1ee673129c276f72c8d7c2974091af7618a22c2a" Date: Mon, 1 Feb 2016 23:09:49 +0000 Subject: Added a comment: Output --- .../comment_1_0c428752e38798f0e8c8a72457c0a670._comment | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 doc/todo/concurrency/comment_1_0c428752e38798f0e8c8a72457c0a670._comment (limited to 'doc/todo') diff --git a/doc/todo/concurrency/comment_1_0c428752e38798f0e8c8a72457c0a670._comment b/doc/todo/concurrency/comment_1_0c428752e38798f0e8c8a72457c0a670._comment new file mode 100644 index 00000000..f5505140 --- /dev/null +++ b/doc/todo/concurrency/comment_1_0c428752e38798f0e8c8a72457c0a670._comment @@ -0,0 +1,8 @@ +[[!comment format=mdwn + username="cmt.miniBill@1ee673129c276f72c8d7c2974091af7618a22c2a" + nickname="cmt.miniBill" + subject="Output" + date="2016-02-01T23:09:49Z" + content=""" +Didn't you solve the output problem for git-annex? +"""]] -- cgit v1.3-2-g0d8e From 1671aae6d464f090f255dfe676e89db5345fd48a Mon Sep 17 00:00:00 2001 From: "cmt.miniBill@1ee673129c276f72c8d7c2974091af7618a22c2a" Date: Tue, 2 Feb 2016 10:23:21 +0000 Subject: --- ...Fix___40__-__62__-__41___signature_in_Propellor.Types.Container.mdwn | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 doc/todo/Fix___40__-__62__-__41___signature_in_Propellor.Types.Container.mdwn (limited to 'doc/todo') diff --git a/doc/todo/Fix___40__-__62__-__41___signature_in_Propellor.Types.Container.mdwn b/doc/todo/Fix___40__-__62__-__41___signature_in_Propellor.Types.Container.mdwn new file mode 100644 index 00000000..796802b8 --- /dev/null +++ b/doc/todo/Fix___40__-__62__-__41___signature_in_Propellor.Types.Container.mdwn @@ -0,0 +1,2 @@ +Please merge this commit +https://github.com/miniBill/propellor/commit/0d9cd127c3448998aa4e4d20a8ce4083ee4b4362 -- cgit v1.3-2-g0d8e From 218060d05467812ddbd4b3f0e59fc4f10f08b659 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 2 Feb 2016 12:04:53 -0400 Subject: close --- doc/todo/concurrency.mdwn | 3 +++ .../comment_2_d259eb0ff27327cc94542c9374d3da90._comment | 8 ++++++++ 2 files changed, 11 insertions(+) create mode 100644 doc/todo/concurrency/comment_2_d259eb0ff27327cc94542c9374d3da90._comment (limited to 'doc/todo') diff --git a/doc/todo/concurrency.mdwn b/doc/todo/concurrency.mdwn index fa0e22ea..0d1dc847 100644 --- a/doc/todo/concurrency.mdwn +++ b/doc/todo/concurrency.mdwn @@ -109,3 +109,6 @@ responsible for such output, but it could be printed out, with appropriate warnings, at the end. [[!tag user/joey]] + +> [[done]]; use Propellor.Property.Concurrent to make properties run +> concurrently. --[[Joey]] diff --git a/doc/todo/concurrency/comment_2_d259eb0ff27327cc94542c9374d3da90._comment b/doc/todo/concurrency/comment_2_d259eb0ff27327cc94542c9374d3da90._comment new file mode 100644 index 00000000..b2f2e192 --- /dev/null +++ b/doc/todo/concurrency/comment_2_d259eb0ff27327cc94542c9374d3da90._comment @@ -0,0 +1,8 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 2""" + date="2016-02-02T16:04:31Z" + content=""" +Oh I forgot to close this. Propellor has had Propellor.Property.Concurrent +for a while. +"""]] -- cgit v1.3-2-g0d8e From fcd124fe7e28e7abdfa8db15a4fbc3524aa98de0 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 2 Feb 2016 12:06:56 -0400 Subject: close --- ...Fix___40__-__62__-__41___signature_in_Propellor.Types.Container.mdwn | 2 ++ 1 file changed, 2 insertions(+) (limited to 'doc/todo') diff --git a/doc/todo/Fix___40__-__62__-__41___signature_in_Propellor.Types.Container.mdwn b/doc/todo/Fix___40__-__62__-__41___signature_in_Propellor.Types.Container.mdwn index 796802b8..58c9b5ca 100644 --- a/doc/todo/Fix___40__-__62__-__41___signature_in_Propellor.Types.Container.mdwn +++ b/doc/todo/Fix___40__-__62__-__41___signature_in_Propellor.Types.Container.mdwn @@ -1,2 +1,4 @@ Please merge this commit https://github.com/miniBill/propellor/commit/0d9cd127c3448998aa4e4d20a8ce4083ee4b4362 + +> [[done]], thanks --[[Joey]] -- cgit v1.3-2-g0d8e From 5efbf179bc0be8528c8aad39870169ec24d98510 Mon Sep 17 00:00:00 2001 From: "mithrandi@311efa1b2b5c4999c2edae7da06fb825899e8a82" Date: Fri, 26 Feb 2016 13:06:38 +0000 Subject: Added a comment --- .../comment_2_5b5c8217eeb48159109b453197694db3._comment | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 doc/todo/revertable_Ssh.authorizedKey/comment_2_5b5c8217eeb48159109b453197694db3._comment (limited to 'doc/todo') diff --git a/doc/todo/revertable_Ssh.authorizedKey/comment_2_5b5c8217eeb48159109b453197694db3._comment b/doc/todo/revertable_Ssh.authorizedKey/comment_2_5b5c8217eeb48159109b453197694db3._comment new file mode 100644 index 00000000..ddadd4f4 --- /dev/null +++ b/doc/todo/revertable_Ssh.authorizedKey/comment_2_5b5c8217eeb48159109b453197694db3._comment @@ -0,0 +1,8 @@ +[[!comment format=mdwn + username="mithrandi@311efa1b2b5c4999c2edae7da06fb825899e8a82" + nickname="mithrandi" + subject="comment 2" + date="2016-02-26T13:06:38Z" + content=""" +Ssh.unauthorizedKey exists now; is there a reason not to add it to authorizedKey to make it revertable? +"""]] -- cgit v1.3-2-g0d8e From 05b698f8b2ef2969124a0389e5475bbb2c0d26bf Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 26 Feb 2016 11:03:49 -0400 Subject: close --- doc/todo/revertable_Ssh.authorizedKey.mdwn | 2 ++ .../comment_3_54b1c00246663c845a1b919ccdc168fd._comment | 7 +++++++ 2 files changed, 9 insertions(+) create mode 100644 doc/todo/revertable_Ssh.authorizedKey/comment_3_54b1c00246663c845a1b919ccdc168fd._comment (limited to 'doc/todo') diff --git a/doc/todo/revertable_Ssh.authorizedKey.mdwn b/doc/todo/revertable_Ssh.authorizedKey.mdwn index f92eaee8..79c59bcc 100644 --- a/doc/todo/revertable_Ssh.authorizedKey.mdwn +++ b/doc/todo/revertable_Ssh.authorizedKey.mdwn @@ -1 +1,3 @@ I recently lost the security key I store my primary SSH key on, and had to remove that key from all authorized_keys files I had access to. It would be great if Ssh.authorizedKey was revertable, so that this could be done simply by adding a ! before existing Ssh.authorizedKey lines. + +> [[done]] --[[Joey]] diff --git a/doc/todo/revertable_Ssh.authorizedKey/comment_3_54b1c00246663c845a1b919ccdc168fd._comment b/doc/todo/revertable_Ssh.authorizedKey/comment_3_54b1c00246663c845a1b919ccdc168fd._comment new file mode 100644 index 00000000..e6ba53cb --- /dev/null +++ b/doc/todo/revertable_Ssh.authorizedKey/comment_3_54b1c00246663c845a1b919ccdc168fd._comment @@ -0,0 +1,7 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 3""" + date="2016-02-26T14:56:36Z" + content=""" +No particular reason. I've made the change. +"""]] -- cgit v1.3-2-g0d8e From faba0482eb71df06ac0ddb1e134289b5b3d45ec0 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Wed, 2 Mar 2016 15:34:16 -0400 Subject: update --- doc/todo/type_level_port_conflict_detection.mdwn | 3 +++ 1 file changed, 3 insertions(+) (limited to 'doc/todo') diff --git a/doc/todo/type_level_port_conflict_detection.mdwn b/doc/todo/type_level_port_conflict_detection.mdwn index 6708ac3a..47d5f0cf 100644 --- a/doc/todo/type_level_port_conflict_detection.mdwn +++ b/doc/todo/type_level_port_conflict_detection.mdwn @@ -4,4 +4,7 @@ Needs ghc newer than 7.6.3. It may be possible to port Data.Type.Equality and Data.Type.Bool to older versions; I got them to compile but they didn't work right. --[[Joey]] +I have a `resourceconflict` branch that adds this in Propellor.Resources, +but it is not yet integrated into the Property types. --[[Joey]] + [[!tag user/joey]] -- cgit v1.3-2-g0d8e