From 680f67970dcb25fac43e96bb732be1e53ffdffe5 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 4 Apr 2017 16:46:38 -0400 Subject: bug report --- doc/todo/initial_spin_compile_failure_recovery.mdwn | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 doc/todo/initial_spin_compile_failure_recovery.mdwn (limited to 'doc') diff --git a/doc/todo/initial_spin_compile_failure_recovery.mdwn b/doc/todo/initial_spin_compile_failure_recovery.mdwn new file mode 100644 index 00000000..423b279c --- /dev/null +++ b/doc/todo/initial_spin_compile_failure_recovery.mdwn @@ -0,0 +1,5 @@ +When initial propellor --spin host fails to compile propellor +perhaps due to a ghc compatability bug, spinning again doesn't fix the +problem. IIRC /usr/local/propellor has a git repo set up, but no remote +set, and so the subsequent spin doesn't update it, since propellor is not +running there to receive a git push into the repo. --[[Joey]] -- cgit v1.3-2-g0d8e From 2afeb3661f04beb0a84b740b327917c16ed27a3d Mon Sep 17 00:00:00 2001 From: "db48x@80bd751a72d5a80737e2f875342cf845629c7202" Date: Tue, 4 Apr 2017 21:07:53 +0000 Subject: --- doc/forum/Git.cloned_deletes_harmless_empty_directory.mdwn | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 doc/forum/Git.cloned_deletes_harmless_empty_directory.mdwn (limited to 'doc') diff --git a/doc/forum/Git.cloned_deletes_harmless_empty_directory.mdwn b/doc/forum/Git.cloned_deletes_harmless_empty_directory.mdwn new file mode 100644 index 00000000..ce3c192c --- /dev/null +++ b/doc/forum/Git.cloned_deletes_harmless_empty_directory.mdwn @@ -0,0 +1,3 @@ +In my case I have carefully set up the directory that I'm going to clone into with the correct group ownership and setgid permission, so that the cloned files will also have the correct ownership. This change just checks to see if the directory actually has anything in it before it deletes it. + +https://github.com/ArchiveTeam/glowing-computing-machine/tree/git-in-emtpy-directory -- cgit v1.3-2-g0d8e From 1573c094362be744517d7d5e909a2148e6d79618 Mon Sep 17 00:00:00 2001 From: "db48x@80bd751a72d5a80737e2f875342cf845629c7202" Date: Tue, 4 Apr 2017 21:10:01 +0000 Subject: --- doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap.mdwn | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap.mdwn (limited to 'doc') diff --git a/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap.mdwn b/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap.mdwn new file mode 100644 index 00000000..61cd10cc --- /dev/null +++ b/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap.mdwn @@ -0,0 +1,3 @@ +The mount command won't work when activating a swap partition/file, so we should call swapon instead. + +https://github.com/ArchiveTeam/glowing-computing-machine/tree/fstab-swap -- cgit v1.3-2-g0d8e From 7a2a88c12805f277e1e89e63b006a0783ea8cc0b Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 4 Apr 2017 22:31:00 -0400 Subject: comments --- ...mment_1_8ab6b313c80486f8f87a5e13e830bfa9._comment | 20 ++++++++++++++++++++ ...mment_1_7cd0521c6d071b25852f8355f4f61f94._comment | 20 ++++++++++++++++++++ 2 files changed, 40 insertions(+) create mode 100644 doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_1_8ab6b313c80486f8f87a5e13e830bfa9._comment create mode 100644 doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_1_7cd0521c6d071b25852f8355f4f61f94._comment (limited to 'doc') diff --git a/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_1_8ab6b313c80486f8f87a5e13e830bfa9._comment b/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_1_8ab6b313c80486f8f87a5e13e830bfa9._comment new file mode 100644 index 00000000..4a144df5 --- /dev/null +++ b/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_1_8ab6b313c80486f8f87a5e13e830bfa9._comment @@ -0,0 +1,20 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 1""" + date="2017-04-05T02:17:00Z" + content=""" +This idea kind of makes sense, because swap partitions in /etc/fstab +get swaponed at boot. + +But, the implementation doesn't take the types into account. The `mounted` +property takes a FilePath for the mountpoint, but for swap that +needs to be "none", which is not really a file-path. Also, the `fstabbed` +property has a separate `SwapPartition` type, so making `mount` support +swap partitions without using that type feels wrong. + +It might be simpler all round to treat swap partitions being able to +be specified in /etc/fstab as a historical accident, which it kind of +is (increasingly so, since eg systemd has other ways to accomplish +that), and instead of shoehorning this into the `mounted` property, +add a new `swaponed` property. +"""]] diff --git a/doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_1_7cd0521c6d071b25852f8355f4f61f94._comment b/doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_1_7cd0521c6d071b25852f8355f4f61f94._comment new file mode 100644 index 00000000..91b403b0 --- /dev/null +++ b/doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_1_7cd0521c6d071b25852f8355f4f61f94._comment @@ -0,0 +1,20 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 1""" + date="2017-04-05T02:22:54Z" + content=""" +I am not entirely happy with this patch, because it seems that if +Git.cloned took care to preserve permissions in this case, it could be +argued that it should also preserve permissions when the directory already +exists but has the wrong content. Or equally well argued that it should not +preserve permissions, which might be a leftover from some past unwanted +state. + +Is that really the best way to do it? You could instead say: + + Git.cloned user repo dir Nothing + `onChange` recursiveSetGID user dir + +And then you just have to write a recursiveSetGID which would be a +generally useful property. +"""]] -- cgit v1.3-2-g0d8e From 9e6eff4e9fb0859c67d58b8beaf96fe0b472ac21 Mon Sep 17 00:00:00 2001 From: "db48x@80bd751a72d5a80737e2f875342cf845629c7202" Date: Wed, 5 Apr 2017 02:37:45 +0000 Subject: Added a comment --- .../comment_2_289f157f129511242d93beae76fd03a3._comment | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_2_289f157f129511242d93beae76fd03a3._comment (limited to 'doc') diff --git a/doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_2_289f157f129511242d93beae76fd03a3._comment b/doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_2_289f157f129511242d93beae76fd03a3._comment new file mode 100644 index 00000000..1a8c1447 --- /dev/null +++ b/doc/forum/Git.cloned_deletes_harmless_empty_directory/comment_2_289f157f129511242d93beae76fd03a3._comment @@ -0,0 +1,11 @@ +[[!comment format=mdwn + username="db48x@80bd751a72d5a80737e2f875342cf845629c7202" + nickname="db48x" + avatar="http://cdn.libravatar.org/avatar/ad2688127feb555a92154b16d8eeb5d3" + subject="comment 2" + date="2017-04-05T02:37:44Z" + content=""" +Yea, I guess that's a fair point about the other cases. + +It just seems inelegant to go back over all the files and fix up their permissions, when it could just have been set right to begin with. +"""]] -- cgit v1.3-2-g0d8e From c14d4430bc70f69f41b2645f3ea25869d4f759bb Mon Sep 17 00:00:00 2001 From: "db48x@80bd751a72d5a80737e2f875342cf845629c7202" Date: Wed, 5 Apr 2017 02:48:08 +0000 Subject: Added a comment --- .../comment_2_773fc1441dd06e9dd41508bd800298eb._comment | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_2_773fc1441dd06e9dd41508bd800298eb._comment (limited to 'doc') diff --git a/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_2_773fc1441dd06e9dd41508bd800298eb._comment b/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_2_773fc1441dd06e9dd41508bd800298eb._comment new file mode 100644 index 00000000..62cabc0a --- /dev/null +++ b/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_2_773fc1441dd06e9dd41508bd800298eb._comment @@ -0,0 +1,13 @@ +[[!comment format=mdwn + username="db48x@80bd751a72d5a80737e2f875342cf845629c7202" + nickname="db48x" + avatar="http://cdn.libravatar.org/avatar/ad2688127feb555a92154b16d8eeb5d3" + subject="comment 2" + date="2017-04-05T02:48:08Z" + content=""" +Yes, perhaps if it took an Option FilePath (am I saying this correctly in Haskellese?) it would be nicer. + +I don't mind much how it's structured; this was just the smallest obvious change, since it was failing to mount it. Perhaps breaking it up into smaller, more primitive, pieces would help. Fstab.mounted could = Fstab.fstabbed `onChange` Fstab.mounted, for instance, and then I could write Fstab.fstabbed `onChange` Swap.swapEnabled (oh, but Fstab.fstabbed already exists; I'm not using it because it replaces the whole file, which seems like an odd thing to do. Maybe call it Fstab.listed instead?). + +Also, for maximum irony I was just perusing your most recent dozen commits or so, and saw you enable Apt.serviceInstalledRunning \"swapspace\" on one of your machines. That's amazing; I had no idea it existed! I am re-evaluating all of my life choices now. +"""]] -- cgit v1.3-2-g0d8e From fcc5b96e595a20a8b93989fa59f2b73d1b6d3a1b Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 4 Apr 2017 23:12:39 -0400 Subject: comment --- .../comment_3_f48a6191c56bed41eda55436f0aa3e9c._comment | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_3_f48a6191c56bed41eda55436f0aa3e9c._comment (limited to 'doc') diff --git a/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_3_f48a6191c56bed41eda55436f0aa3e9c._comment b/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_3_f48a6191c56bed41eda55436f0aa3e9c._comment new file mode 100644 index 00000000..95c69551 --- /dev/null +++ b/doc/forum/Fstab.mounted_could_call_swapon_when_activating_swap/comment_3_f48a6191c56bed41eda55436f0aa3e9c._comment @@ -0,0 +1,15 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 3""" + date="2017-04-05T03:08:30Z" + content=""" +I like the idea of composing smaller properties to build the current +property, and add flexability. + +Renaming the existing `fstabbed` would probably be too much bother. +(Also, I think I picked that name because it kind of hints that the +existing fstab does not come out alive.) + +(The swapspace package is great if you can eat the now tiny overhead of a +swap file compared to a swap partition.) +"""]] -- cgit v1.3-2-g0d8e