diff options
| author | Joey Hess <joeyh@joeyh.name> | 2017-06-18 18:24:05 -0400 |
|---|---|---|
| committer | Joey Hess <joeyh@joeyh.name> | 2017-06-18 18:24:05 -0400 |
| commit | 01fc1375cece096ab2dec480b843ecdbc4f0d94e (patch) | |
| tree | fb620f98f3e891eac092d31ed5ab43a8975bd3a0 /doc/coding_style.mdwn | |
| parent | 9b457ae66d5c5143f5896156cc4af8d5a0bc0ddc (diff) | |
Fix bug that sometimes made --spin fail with "fatal: Couldn't find remote ref HEAD"
Tricky stdin buffering problem.
An easier fix would have been:
hSetBuffering stdin NoBuffering
But that approach is less robust; even with NoBuffering, anything that
uses hLookAhead causes 1 byte of buffering. And, any reads from stdin
before hSetBuffering would still cause the problem. Instead, I used a
bigger hammer that will always work. It involves a bit more CPU work,
but this is data that is already being fed through ssh; copying it one
more time won't cause a measurable performance impact.
This commit was sponsored by Jack Hill on Patreon.
Diffstat (limited to 'doc/coding_style.mdwn')
0 files changed, 0 insertions, 0 deletions
