diff options
| author | Joey Hess <joeyh@joeyh.name> | 2016-06-20 14:03:05 -0400 |
|---|---|---|
| committer | Joey Hess <joeyh@joeyh.name> | 2016-06-20 14:03:05 -0400 |
| commit | 1b928982d74e029c02d22905c222ab1730906d10 (patch) | |
| tree | ddb6d168c9977583eb9826e30dd3fb3d52ca51fd /doc/todo/merge_request:_changes_to_Reboot.hs | |
| parent | 0193c44df02298a929362ce5f7dc11e28dfa852f (diff) | |
comment
Diffstat (limited to 'doc/todo/merge_request:_changes_to_Reboot.hs')
| -rw-r--r-- | doc/todo/merge_request:_changes_to_Reboot.hs/comment_9_233140189ee7ffebad687db76dfe2258._comment | 22 |
1 files changed, 22 insertions, 0 deletions
diff --git a/doc/todo/merge_request:_changes_to_Reboot.hs/comment_9_233140189ee7ffebad687db76dfe2258._comment b/doc/todo/merge_request:_changes_to_Reboot.hs/comment_9_233140189ee7ffebad687db76dfe2258._comment new file mode 100644 index 00000000..1afbef11 --- /dev/null +++ b/doc/todo/merge_request:_changes_to_Reboot.hs/comment_9_233140189ee7ffebad687db76dfe2258._comment @@ -0,0 +1,22 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 9""" + date="2016-06-20T17:56:25Z" + content=""" +Félix sent some patches today fixing compiling Propellor.Exception on old +ghc, which overlap with part of your patch. You addressed the same problem +in different ways. Since I already merged his (more extensive I think) +fixes for that, your branch will need to be updated. + +The only thing I caught during review is that the documentation for +useOverlays says that the property has to be added before +Sbuild.builtFor, but actually info-setting properties +set info before any properties run, so can safely appear after properties +that use the info they set! + +(I'm not sure if overlaysInTmpfs can safely come after +Sbuild.builtFor, but if it cannot it's not due to setting useOverlays.) + +Also, it would be good to have some lines to add to the changelog +about the sbuild changes. +"""]] |