diff options
| author | Joey Hess <joeyh@joeyh.name> | 2016-03-07 16:36:36 -0400 |
|---|---|---|
| committer | Joey Hess <joeyh@joeyh.name> | 2016-03-07 16:36:36 -0400 |
| commit | 16a95afa2fe22a4df9c371489c4ee7ffdef8e07b (patch) | |
| tree | 6e0869e78aba03be2591569369e1e099bb86568e /doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties | |
| parent | 9bbc292b3f903a1476e3524bb9198e58ce300401 (diff) | |
| parent | 822694e790102efa2a5bb4a0c3d62c6fce1d4e87 (diff) | |
Merge remote-tracking branch 'remotes/misandrist/FreeBSD' into wip
Diffstat (limited to 'doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties')
2 files changed, 24 insertions, 0 deletions
diff --git a/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties/comment_1_3c528827f40420e3f4001f69127a0c51._comment b/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties/comment_1_3c528827f40420e3f4001f69127a0c51._comment new file mode 100644 index 00000000..4d413c84 --- /dev/null +++ b/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties/comment_1_3c528827f40420e3f4001f69127a0c51._comment @@ -0,0 +1,17 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 1""" + date="2015-11-25T15:24:10Z" + content=""" +The types here don't tell me much about what values it expects. + +`selectedFor :: String -> [String] -> Property NoInfo` + +Function needs either some examples in its haddock, or better types. + +Also, the `available` property incorrectly succeeds if the locale passed to +it is not listed in locale.gen. + +(It would be nice for these properties to be revertable but that's just a +thought.) +"""]] diff --git a/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties/comment_2_981a305c50d699fd3d06c39ca66107ea._comment b/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties/comment_2_981a305c50d699fd3d06c39ca66107ea._comment new file mode 100644 index 00000000..e8801aba --- /dev/null +++ b/doc/todo/pull_request:_Locale.selectedFor_and_Locale.available_properties/comment_2_981a305c50d699fd3d06c39ca66107ea._comment @@ -0,0 +1,7 @@ +[[!comment format=mdwn + username="spwhitton" + subject="comment 2" + date="2015-11-26T02:51:22Z" + content=""" +Thanks for the feedback. I've implemented your suggestions. Please take a look. +"""]] |