diff options
| author | spwhitton <spwhitton@web> | 2015-12-06 22:24:06 +0000 |
|---|---|---|
| committer | admin <admin@branchable.com> | 2015-12-06 22:24:06 +0000 |
| commit | 086563af61f4cdc3c9041167d3002a7f0089902c (patch) | |
| tree | f25dc1b1eb80bc5dd13578cc6916acd461c4c355 /doc | |
| parent | aad109c66f57abbfc5cfb0dc8288928ee9a01a7e (diff) | |
Added a comment
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN/comment_2_3ddaec3927b4a4aefad45a02e83476dc._comment | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN/comment_2_3ddaec3927b4a4aefad45a02e83476dc._comment b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN/comment_2_3ddaec3927b4a4aefad45a02e83476dc._comment new file mode 100644 index 00000000..045cd927 --- /dev/null +++ b/doc/todo/proposal:_env_vars_PROPELLOR__95__SPIN__95__BRANCH___38___PROPELLOR__95__DIRTY__95__NOSPIN/comment_2_3ddaec3927b4a4aefad45a02e83476dc._comment @@ -0,0 +1,9 @@ +[[!comment format=mdwn + username="spwhitton" + subject="comment 2" + date="2015-12-06T22:24:06Z" + content=""" +I was thinking environment variables because I saw both of these as just safety checks for the user, spinning hosts from their xterm on their laptop. I'll implement both as `git-config` variables; that's a good idea as it covers more cases. + +I don't think that this patch need touch the propellor executable run by `Cron.runPropellor`, because if the check has already ensured that the correct branch got pushed to the host during the most recent spin, then `propellor_cronjob` is guaranteed to pull the correct branch. +"""]] |