clean up privdata excess/lacking newline issue

* PrivData converted to newtype (API change).
* Stopped stripping trailing newlines when setting PrivData;
  this was previously done to avoid mistakes when pasting eg passwords
  with an unwanted newline. Instead, PrivData consumers should use either
  privDataLines or privDataVal, to extract respectively lines or a
  value (without internal newlines) from PrivData.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/Propellor/Property/User.hs b/src/Propellor/Property/User.hs
index add3ae52..c029999f 100644
--- a/src/Propellor/Property/User.hs
+++ b/src/Propellor/Property/User.hs
@@ -58,8 +58,8 @@ hasPassword' (User u) context = go `requires` shadowConfig True
 setPassword :: (((PrivDataField, PrivData) -> Propellor Result) -> Propellor Result) -> Propellor Result
 setPassword getpassword = getpassword $ go
   where
-	go (Password user, password) = set user password []
-	go (CryptPassword user, hash) = set user hash ["--encrypted"]
+	go (Password user, password) = set user (privDataVal password) []
+	go (CryptPassword user, hash) = set user (privDataVal hash) ["--encrypted"]
 	go (f, _) = error $ "Unexpected type of privdata: " ++ show f
 
 	set user v ps = makeChange $ withHandle StdinHandle createProcessSuccess